Skip to content

chore: dismiss Dependabot review requests - #44

Merged
Pigbibi merged 1 commit into
mainfrom
agent/dismiss-dependabot-review-requests
Jul 20, 2026
Merged

chore: dismiss Dependabot review requests#44
Pigbibi merged 1 commit into
mainfrom
agent/dismiss-dependabot-review-requests

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • dismiss Pigbibi review requests automatically generated for Dependabot PRs
  • recognize both dependabot[bot] and app/dependabot identities
  • require the review-request event actor to be Dependabot
  • re-check the latest Pigbibi review-request actor from the PR timeline immediately before deletion
  • preserve later or concurrent review requests made by maintainers
  • keep concurrent review-request runs instead of cancelling the matching cleanup
  • use pull_request_target with metadata-only GitHub API access and no checkout

Why

These repositories already auto-merge eligible non-major Dependabot updates after CI, but CODEOWNERS creates redundant review notifications. Event-actor and timeline checks let the workflow remove only bot-generated requests without touching human review requests, including race conditions while a run is queued.

Validation

  • verified automatic CODEOWNERS timeline actor on a historical Dependabot PR
  • verified both supported Dependabot identities
  • verified requested reviewer, event actor, and latest timeline actor conditions
  • verified API errors fail instead of being treated as no match
  • verified no checkout or execution of PR code
  • bash syntax check
  • git diff --check

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

🤖 Codex PR Review

Merge allowed: 1 finding(s) reported but none are blocking

ℹ️ Other Findings

1. 🟡 [MEDIUM] Logic in .github/workflows/dependabot_review_request_cleanup.yml

The workflow calls issues/{PR_NUMBER}/timeline?per_page=100 once and then treats [-1] from that single page as the latest review_requested event for Pigbibi. GitHub paginates timeline results, so for pull requests with more than 100 timeline events this only inspects the first page, not the true most recent matching event. In that reachable case, the job can misclassify the current review request and either delete a maintainer-requested review or fail to dismiss the redundant Dependabot-generated one. (line 39)

Suggestion: Fetch the complete matching history before selecting the latest event, or query pages until exhaustion and then choose the last matching review_requested event. At minimum, use pagination-aware gh api --paginate handling before computing the final actor.


Review by Codex PR Review bot • PR

@Pigbibi
Pigbibi force-pushed the agent/dismiss-dependabot-review-requests branch from 7d3b38c to 858e3e1 Compare July 20, 2026 05:54

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 858e3e129c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/dependabot_review_request_cleanup.yml Outdated
Comment thread .github/workflows/dependabot_review_request_cleanup.yml Outdated
@Pigbibi
Pigbibi force-pushed the agent/dismiss-dependabot-review-requests branch from 858e3e1 to a871285 Compare July 20, 2026 05:58

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a871285386

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/dependabot_review_request_cleanup.yml
@Pigbibi
Pigbibi force-pushed the agent/dismiss-dependabot-review-requests branch 2 times, most recently from ade3259 to 381c13d Compare July 20, 2026 06:04
@Pigbibi
Pigbibi enabled auto-merge (squash) July 20, 2026 06:08
@Pigbibi
Pigbibi force-pushed the agent/dismiss-dependabot-review-requests branch from 381c13d to 6799911 Compare July 20, 2026 06:12
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi force-pushed the agent/dismiss-dependabot-review-requests branch from 6799911 to cb025fa Compare July 20, 2026 06:15
@Pigbibi
Pigbibi merged commit 59ab556 into main Jul 20, 2026
3 checks passed
@Pigbibi
Pigbibi deleted the agent/dismiss-dependabot-review-requests branch July 20, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant